Skip to content

x/mobile/gl: use EGL to determine the version of OpenGL ES#69

Open
BenLubar wants to merge 4 commits intogolang:masterfrom
BenLubar:egl
Open

x/mobile/gl: use EGL to determine the version of OpenGL ES#69
BenLubar wants to merge 4 commits intogolang:masterfrom
BenLubar:egl

Conversation

@BenLubar
Copy link

@BenLubar BenLubar commented Jul 2, 2021

No description provided.

@google-cla google-cla bot added the cla: yes label Jul 2, 2021
@gopherbot
Copy link
Contributor

gopherbot commented Jul 2, 2021

This PR (HEAD: 50ede83) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/332429 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

gopherbot commented Jul 9, 2021

Message from Hyang-Ah Hana Kim:

Patch Set 1: Run-TryBot+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332429.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jul 9, 2021

Message from Go Bot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332429.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jul 9, 2021

Message from Go Bot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332429.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jul 9, 2021

Message from Ben Lubar:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332429.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jul 9, 2021

This PR (HEAD: 865f9d6) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/332429 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

gopherbot commented Jul 9, 2021

Message from Hyang-Ah Hana Kim:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332429.
After addressing review feedback, remember to publish your drafts!

@BenLubar
bail out of init early if an error is encountered for maximum correct…
daa7304 
…ness

call eglTerminate before init returns. if another init on the same OS thread has already created a context, eglTerminate is a no-op until the context is destroyed. otherwise, this allows scenarios where a program that imports x/mobile/gl might want to call eglInitialize on a different display.
@gopherbot
Copy link
Contributor

gopherbot commented Jul 9, 2021

This PR (HEAD: daa7304) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/332429 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

gopherbot commented Jul 9, 2021

Message from Ben Lubar:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332429.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jul 9, 2021

Message from Hyang-Ah Hana Kim:

Patch Set 3: Run-TryBot+1 Code-Review+2 Trust+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332429.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jul 9, 2021

Message from Go Bot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332429.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jul 9, 2021

Message from Go Bot:

Patch Set 3: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332429.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jul 11, 2021

Message from Hajime Hoshi:

Patch Set 3: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/332429.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jul 11, 2021

Message from Hajime Hoshi:

Patch Set 3: Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/332429.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jul 11, 2021

Message from Hajime Hoshi:

Patch Set 3: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332429.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Aug 7, 2021

This PR (HEAD: c24693c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/332429 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2021

Message from Hyang-Ah Hana Kim:

Patch Set 1: Run-TryBot+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332429.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2021

Message from Go Bot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332429.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2021

Message from Go Bot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332429.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2021

Message from Ben Lubar:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332429.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2021

Message from Hyang-Ah Hana Kim:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332429.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2021

Message from Ben Lubar:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332429.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2021

Message from Hyang-Ah Hana Kim:

Patch Set 3: Run-TryBot+1 Code-Review+2 Trust+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332429.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2021

Message from Go Bot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332429.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2021

Message from Go Bot:

Patch Set 3: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332429.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2021

Message from Hajime Hoshi:

Patch Set 3: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/332429.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2021

Message from Hajime Hoshi:

Patch Set 3: Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/332429.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2021

Message from Hajime Hoshi:

Patch Set 3: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332429.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BenLubar @gopherbot